Make -check-api-availability-only a driver flag and don't pass to verification jobs #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ification jobs Promote the flag -check-api-availability-only to a driver flag. Pass it down to all compilation jobs except swiftinterface verification. rdar://84680002
|
@swift-ci Please test |
artemcm
reviewed
Oct 26, 2021
| @@ -48,7 +48,7 @@ extension Option { | |||
| public static let buildModuleFromParseableInterface: Option = Option("-build-module-from-parseable-interface", .flag, alias: Option.compileModuleFromInterface, attributes: [.helpHidden, .frontend, .noDriver], group: .modes) | |||
| public static let bypassBatchModeChecks: Option = Option("-bypass-batch-mode-checks", .flag, attributes: [.helpHidden, .frontend, .noDriver], helpText: "Bypass checks for batch-mode errors.") | |||
| public static let candidateModuleFile: Option = Option("-candidate-module-file", .separate, attributes: [.helpHidden, .frontend, .noDriver], metaVar: "<path>", helpText: "Specify Swift module may be ready to use for an interface") | |||
| public static let checkApiAvailabilityOnly: Option = Option("-check-api-availability-only", .flag, attributes: [.helpHidden, .frontend, .noDriver], helpText: "Only check the availability of the APIs, ignore function bodies") | |||
| public static let checkApiAvailabilityOnly: Option = Option("-check-api-availability-only", .flag, attributes: [.helpHidden, .frontend, .noInteractive], helpText: "Only check the availability of the APIs, ignore function bodies") | |||
There was a problem hiding this comment.
I think this is still a change we should be making in the swift repo and legacy driver first, still. 😞
Otherwise when folks are updating this automatically this change won't be preserved.
There was a problem hiding this comment.
Ah, just saw the respective swift pr! 👍🏼
There was a problem hiding this comment.
You were too fast!
What's confusing about this is that we need to update the .td files in the compiler's repo, while having an updated driver to run the test on the compiler side.
artemcm
approved these changes
Oct 26, 2021
nkcsgexi
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote the flag -check-api-availability-only to a driver flag. Pass it down to compilation jobs but not swiftinterface verification.
rdar://84680002
C++ driver PR: swiftlang/swift#39928