Pass-down -downgrade-typecheck-interface-error to interface verification job #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Can we pass it down only when the verification is not explicitly requested as discussed earlier today? |
nkcsgexi
force-pushed
the
use-warning-interface-verify
branch
from
3a16b11 to
9885763
Compare
|
@swift-ci please test |
|
@xymus sure, additional check added. |
…ion job The interface verification phase should downgrade errors to warnings as an intermediate step to stage it in. This won't fail the build if interface errors occur but it should help users verify project-side fixes.
nkcsgexi
force-pushed
the
use-warning-interface-verify
branch
from
9885763 to
504d9d7
Compare
|
@swift-ci please test |
xymus
approved these changes
Nov 11, 2021
|
Thanks for the env var support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface verification phase should downgrade errors to warnings as an
intermediate step to stage it in. This won't fail the build if interface errors
occur but it should help users verify project-side fixes.