Tests: correct environment testing for Windows #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate mode execution will not set an environment variable (i.e. `DYLD_LIBRARY_PATH` or `LD_LIBRARY_PATH`) as the runtime components are searched for by `Path` or by the explicit path that a manifest may provide for a UWP application.
|
@swift-ci please test |
| if driver.targetTriple.isDarwin { | ||
| envVar = "DYLD_LIBRARY_PATH" | ||
| } else if driver.targetTriple.isWindows { | ||
| envVar = "Path" |
There was a problem hiding this comment.
We don’t have any assertions for this case. If I understand the comment below, there isn’t anything to assert?
There was a problem hiding this comment.
Correct; there is nothing to really assert on - Path is always part of the environment. So the assertion would check absolutely nothing.
cltnschlosser
approved these changes
Dec 21, 2021
artemcm
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate mode execution will not set an environment variable (i.e.
DYLD_LIBRARY_PATHorLD_LIBRARY_PATH) as the runtime components aresearched for by
Pathor by the explicit path that a manifest mayprovide for a UWP application.