[5.6] SwiftDriver: address TODO about abnormal process termination #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the handling for abnormal process termination on Windows. With this, we can now track processes which exit abnormally, indicating failure. This was identified by the saveTemps test which now passes on Windows. Add an additional test case for the new message type to differentiate the abnormal exit due to an exception from a signalled exit which is limited to Unixish platforms.
|
@swift-ci please test |
compnerd
changed the title
|
This is needed to repair the build on Windows, but there is no 5.6 snapshot yet which prevents testing. Could we still get this merged @artemcm? (In theory there is a circular dependency here - we need this to build for Windows, which is needed to get a snapshot). |
|
I've tested this locally and verified that this repairs the build. The associated change for swiftlang/swift-tools-support-core#272 was merged without this change. I really dropped the ball on this, sorry about the trouble. |
DougGregor
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the handling for abnormal process termination on Windows.
With this, we can now track processes which exit abnormally, indicating
failure. This was identified by the saveTemps test which now passes on
Windows. Add an additional test case for the new message type to
differentiate the abnormal exit due to an exception from a signalled
exit which is limited to Unixish platforms.