[CMake Build] Build and link driver dependencies as static libraries #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
commented
Jan 5, 2022
artemcm
force-pushed
the
CMakeBuildStaticDeps
branch
2 times, most recently
from
795f1a6 to
1d38b4f
Compare
artemcm
force-pushed
the
CMakeBuildStaticDeps
branch
from
1d38b4f to
c725ec1
Compare
|
@swift-ci please test |
artemcm
changed the title
|
Cross-repo tests in swiftlang/swift#40754 are green, including toolchain builds. |
|
not a CMake expert, but seems good to me 👍 |
compnerd
reviewed
Jan 22, 2022
neonichu
approved these changes
Jan 24, 2022
This will allow us to not install shared libraries of TSC, ArgumentParser, etc. into the toolchain when installing the driver.
artemcm
force-pushed
the
CMakeBuildStaticDeps
branch
from
c725ec1 to
10418ae
Compare
|
@swift-ci please test |
Is it currently being used to build swift-driver? If it is, should we preserve the ability to follow the old (pre-this-PR) code-path? |
|
No, I don't believe that the python script is being used, so it should be okay to merge this and fix that at some later date. |
compnerd
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to not install shared libraries of TSC, ArgumentParser, etc. into the toolchain when installing the driver.
This would also help avoid having to do things like:
#963
#953