Support invoking the Fast Dependency Scanner: -scan-dependencies
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
reviewed
May 13, 2020
| @@ -87,6 +87,9 @@ public enum FileType: String, Hashable, CaseIterable, Codable { | |||
| /// Text-based dylib (TBD) file. | |||
| case tbd | |||
|
|
|||
| /// JSON-based Module Dependency Scanner output | |||
| case JSONDependencies = "dependencies.json" | |||
There was a problem hiding this comment.
I hate to make this one of my few comments, but can you call this jsonDependencies? Values in Swift start with lowercase, including initialisms like this.
| @@ -1586,6 +1586,16 @@ final class SwiftDriverTests: XCTestCase { | |||
| } | |||
| } | |||
|
|
|||
| func testScanDependenciesOption() throws { | |||
| do { | |||
| var driver = try Driver(args: ["swiftc", "-scan-dependencies", "foo.swift"]) | |||
There was a problem hiding this comment.
-scan-dependencies supports other kinds of outputs. Can you feed in arguments to ask it to produce a dependencies file (.d) and make sure that ends up on the resulting command line?
|
@swift-ci please test |
artemcm
force-pushed
the
NewDriverFastDependencyScanner
branch
from
3f6f2ac to
d0cf201
Compare
|
@swift-ci please test |
|
@swift-ci test |
artemcm
force-pushed
the
NewDriverFastDependencyScanner
branch
from
d0cf201 to
9835e6d
Compare
|
Just needed a rebase. |
DougGregor
approved these changes
May 14, 2020
|
@swift-ci test |
fengjixuchui
referenced
this pull request
in fengjixuchui/swift-driver
May 14, 2020
Merge pull request apple#97 from artemcm/NewDriverFastDependencyScanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the additional compiler mode added in: #28515.