[SE-0258] Revision #3 of the proposal, addressing feedback from review #2 #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2 Changes from the second reviewed version * The synthesized storage property is always named with a leading `_` and is always `private`. * The `wrapperValue` property has been renamed to `projectedValue` to make it sufficiently different from `wrappedValue`. This also gives us the "projection" terminology to talk about the `$` property. * The projected property (e.g., `$foo`) always has the same access as the original wrapped property, rather than being artificially limited to `internal`. This reflects the idea that, for property wrapper types that have a projection, the projection is equal in importance to the wrapped value.
michelf
reviewed
Jun 27, 2019
This comment has been minimized.
This comment has been minimized.
eerie444
reviewed
Jun 27, 2019
spadafiva
reviewed
Jun 27, 2019
proposals/0258-property-wrappers.md
Outdated
| @@ -375,7 +375,7 @@ class Foo { | |||
|
|
|||
| Many Cocoa classes implement value-like objects that require explicit copying. | |||
| Swift currently provides an `@NSCopying` attribute for properties to give | |||
| them behavior like Objective-C's `@property(copy)`, invoking the `copy` method | |||
| them behave like Objective-C's `@property(copy)`, invoking the `copy` method | |||
rjmccall
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from the second reviewed version
_and is always
private.wrapperValueproperty has been renamed toprojectedValuetomake it sufficiently different from
wrappedValue. This also givesus the "projection" terminology to talk about the
$property.$foo) always has the same access asthe original wrapped property, rather than being artificially
limited to
internal. This reflects the idea that, for propertywrapper types that have a projection, the projection is equal in
importance to the wrapped value.