Skip to content

AsyncSequence #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 9, 2021
Merged

AsyncSequence #1246

merged 8 commits into from
Jan 9, 2021

Conversation

parkera
Copy link
Contributor

@parkera parkera commented Jan 8, 2021

@DougGregor
Copy link
Member

This is in good shape for a review. I'll schedule and manage it.

@DougGregor DougGregor merged commit fe3a90e into swiftlang:main Jan 9, 2021
stevapple
stevapple reviewed Jan 9, 2021
View reviewed changes
proposals/NNNN-asyncsequence.md

```swift
var it = myFile.lines().makeAsyncIterator()
while let value = try await it.next() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems too late but... Isn’t this line expected to be:

while let line = try await it.next() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- I'll fix this in an update.

@parkera parkera deleted the asyncsequence branch January 22, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevapple stevapple stevapple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parkera @DougGregor @stevapple