[Proposal] New command for creating packages, and template support. #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
proposals/nnnn-package-creation.md
Outdated
| └── MyAppTests | ||
| └── MyAppTests.swift | ||
|
|
||
| 4 directories, 3 files |
There was a problem hiding this comment.
probably can get rid of this line
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
proposals/nnnn-package-creation.md
Outdated
|
|
||
| The template is a JSON file that guides SwiftPM on the directory structure when creating the new package. The configuration includes the following options: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```JSON |
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
proposals/nnnn-package-creation.md
Outdated
|
|
||
| **Example 2** | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```swift |
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
proposals/nnnn-package-creation.md
Outdated
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
remove empty lines when no needed
tomerd
reviewed
May 3, 2021
tomerd
reviewed
May 3, 2021
|
thank you @miggs597, some feedback inline - mostly formatting. looking forward to the pitch thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.