SE-327 Clarifications #1540
Merged
SE-327 Clarifications #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided later in the review process that the initially-proposed rules were too complex for what was gained. This commit changes the rules to match my change-of-heart as posted here: https://forums.swift.org/t/se-0327-second-review-on-actors-and-initialization/54093/8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates are needed for the reviewed SE-327 so the text is more clear and corrected to match review:
Lift and summarize the reasoning for why we can drop redundant global actor isolation from here: [SE-327] Remove redundant global-actor isolation. swift#40868 (comment)
Update the description about delegating initializers and their isolation / Sendability