Revisions to SE-0366 from first round of review #1775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `move` is renamed to `take`. - Dropping a value without using it now requires an explicit `_ = take x` assignment again. - "Movable bindings" are referred to as "bindings with static lifetime", since this term is useful and relevant to other language features. - Additional "alternatives considered" raised during review and pitch discussions were added. - Expansion of "related directions" section contextualizes the `take` operator among other planned features for selective copy control. - Now that [ownership modifiers for parameters](https://forums.swift.org/t/borrow-and-take-parameter-ownership-modifiers/59581) are being pitched, this proposal ties into that one. Based on feedback during the first review, we have gone back to only allowing parameters to be used with the `take` operator if the parameter declaration is `take` or `inout`.
As noted by @Jumhyn and others in evolution discussion, code motion optimizations could still theoretically reorder operations in a way that breaks uniqueness that relies on sequential execution to hold. Use an example that only requires forwarding ownership of a single value to demonstrate the benefit of `take`.
…pes. It would be useful to be able to destructure move-only structs, but doing so in the face of a `deinit` requires suppressing the deinit logic, since deinit needs to start from a fully-initialized value to tear down. We could provide a special operator for methods on such a type to do destructuring in limited situations where it's appropriate for their API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moveis renamed totake._ = take xassignment again.takeoperator among other planned features for selective copy control.takeoperator if the parameter declaration istakeorinout.