Add upcoming feature flag to SE-0352 to match inclusion in compiler #2381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use 'Implemented in' since flags were not added until Swift 5.8 - Annotate that flag is always enabled in Swift 6 language mode
rjmccall
added
LSG
DougGregor
reviewed
Apr 1, 2024
…mented. Co-authored-by: Doug Gregor <[email protected]>
@DougGregor, if this is fine can you merge it? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upcoming feature flag is included for SE-0352 in the definition of upcoming features in the compiler.
The proposal itself notes the possibly of source incompatibilities that should be rare in practice:
https://github.com/apple/swift-evolution/blob/main/proposals/0352-implicit-open-existentials.md#source-compatibility
This PR adds the upcoming feature flag to the proposal header.
The header includes the 'Implemented in' annotation to note that it became available in Swift 5.8, when upcoming feature flags were added. UPDATE: Changed to Swift 6.0 since that is when the UFF was fully implemented.
It also includes the new 'Enabled in Swift 6 language mode' annotation to indicating when the feature will be enabled.
// cc-ing author and review manager to ensure this change is correct
@DougGregor @jckarter