Update CONTRIBUTING.md #2477
Merged
Update CONTRIBUTING.md #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you think about an updated file with an added a header with language from https://github.com/apple/swift?tab=readme-ov-file#contributing-to-swift ? Also added some headers for pull requests and a paragraph about the repo + highlighting the forums as the main place for conversation.
amartini51
reviewed
Jun 11, 2024
CONTRIBUTING.md
Outdated
Comment on lines
16
to
19
| Substantive changes to: | ||
| - existing proposals should only be made with the permission of the proposal authors. Substantive changes to a proposal in the Accepted or Rejected states are discouraged and require the approval of the appropriate evolution workgroup. Substantive changes to a proposal in the Active Review state require the approval of the appropriate evolution workgroup and should be advertised in the review thread. | ||
| - change vision documents require the approval of the appropriate evolution workgroup. | ||
| - documented evolution process require the approval of the Core Team. |
There was a problem hiding this comment.
I found this hard to read when the new text separates the verb from its object across bullet points. It forces you to be inconsistent in the first bullet, since there's more than one sentence.
There was a problem hiding this comment.
@amartini51 agreed after re-reading it with your comment in mind. I added the verb back. What do you think? thanks for you review
There was a problem hiding this comment.
@amartini51, @rjmccall had another suggestion below that I merged in. Let me know your thoughts for the latest copy.
rjmccall
reviewed
Jun 12, 2024
Co-authored-by: John McCall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about an updated file with an added a header with language from the /swift repo?
Also added some headers for pull requests and a paragraph about the repo + highlighting the forums as the main place for conversation.
None of the process language was changed. Mostly reformatting to style.