Proposal: Task.startSynchronously #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

allevato merged 7 commits into swiftlang:main from ktoso:wip-task-synchronously-start

Mar 27, 2025

Contributor

ktoso commented Feb 19, 2025

New Concurrency API that allows to "synchronously start a Task from the calling context", allowing for more detailed control over execution ordering and even access async functions from synchronous contexts.


          Proposal: Task.startSynchronously

b41bec5

ktoso force-pushed the wip-task-synchronously-start branch from 589952b to b41bec5 Compare

February 19, 2025 08:38


          Update NNNN-task-start-synchronously-on-caller-context.md

f55ef57

ktoso mentioned this pull request

[Concurrency] Start task synchronously on caller context swiftlang/swift#79536

Closed

rjmccall added the LSG label

ktoso added 2 commits

March 4, 2025 15:05


          link to partial implementation

b4daebf


          edit filename in text

59b9d9c

Contributor Author

ktoso commented Mar 4, 2025

This should be ready to go!

allevato reviewed

View reviewed changes

Member

allevato left a comment

Some minor editorial changes, but otherwise LGTM. Once you've applied these, I can start the review—thanks!

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated

+                      // SE-NNNN's proposed 'name: String? = nil' would be here
+                      priority: TaskPriority? = nil,
+                      executorPreference taskExecutor: consuming (any TaskExecutor)? = nil,
+                      operation: sending @escaping async throws(Failure) -> Success,

Member

allevato Mar 26, 2025

I think the parameter list was dropped here and in startSynchronouslyDetached—should these by sending @escaping () async throws(Failure) -> Success?

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

proposals/NNNN-task-start-synchronously-on-caller-context.md Outdated Show resolved Hide resolved

ktoso and others added 2 commits

March 26, 2025 22:14


          Apply suggestions from code review

a27f65d

Co-authored-by: Tony Allevato <[email protected]>


          Apply suggestions from code review

8fa35dc

Contributor Author

ktoso commented Mar 26, 2025

Applied all the comments and I removed the isolated(any) from the code because that's not quite how it works, we'll need some custom internal attribute in available to the concurrency runtime to implement these isolation semantics. It would not be publicly accessible though so removed it from the proposal.

Contributor Author

ktoso commented Mar 26, 2025

@allevato I think we're good here. You can kick off the review then -- I'm offline this week but I'll keep an eye on the review thread, thank you!

ktoso requested a review from allevato

March 26, 2025 13:16


          Assign SE-0472.

89c8849

allevato approved these changes

View reviewed changes

allevato merged commit 7d5ae36 into swiftlang:main

Member

allevato commented Mar 27, 2025

Review is started: https://forums.swift.org/t/se-0472-starting-tasks-synchronously-from-caller-context/78883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LSG