Skip to content

Initiate review of SE-0471: Improved Custom SerialExecutor isolation checking for Concurrency Runtime #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
# Improved Custom SerialExecutor isolation checking for Concurrency Runtime

* Proposal: [SE-NNNN](...)
* Proposal: [SE-0471](0471-SerialExecutor-isIsolated.md)
* Author: [Konrad 'ktoso' Malawski](https://github.com/ktoso)
* Review Manager: TBD
* Status: Implemented
* https://github.com/swiftlang/swift/pull/79788
* https://github.com/swiftlang/swift/pull/79946

* Review Manager: [Doug Gregor](https://github.com/DougGregor)
* Status: **Active Review (March 25...April 8, 2025)
* Implementation: https://github.com/swiftlang/swift/pull/79788 & https://github.com/swiftlang/swift/pull/79946
* Pitch: [[Pitch][SerialExecutor] Improved Custom SerialExecutor isolation checking](https://forums.swift.org/t/pitch-serialexecutor-improved-custom-serialexecutor-isolation-checking/78237/)
* Review: TODO

## Introduction

Expand Down Expand Up @@ -102,7 +99,7 @@ In most cases implementing this new API is preferable to implementing `checkIsol

The newly proposed `isIsolatingCurrentContext()` function participates in the previously established runtime isolation checking flow, and happens _before_ any calls to `checkIsolated()` are attempted. The following diagram explains the order of calls issued by the runtime to dynamically verify an isolation when e.g. `assumeIsolated()` is called:

![diagram illustrating which method is called when](nnnn-is-isolated-flow.png)
![diagram illustrating which method is called when](0471-is-isolated-flow.png)



Expand Down