Skip to content

Initial draft of String proposal #1 #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2017
Merged

Initial draft of String proposal #1 #662

merged 4 commits into from
Apr 5, 2017

Conversation

airspeedswift
Copy link
Member

No description provided.

@benrimmington
Copy link
Contributor

The original SE-0134 proposal recommended that nulTerminatedUTF8 should be renamed to nullTerminatedUTF8.

I found a lot of nul terminated strings in the text. Is that a typo and shouldn't it be null terminated strings?

Nevermind, it's the ASCII name for the null character.

benrimmington
benrimmington reviewed Apr 3, 2017
View reviewed changes
proposals/0161-StringRevision1.md Outdated
@@ -0,0 +1,342 @@
# String Revision: Collection Conformance, C Interop, Transcoding

* Proposal: [SE-0161](0161-StringRevision1.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0161 is already taken (by the Smart KeyPaths proposal). All existing filenames are lowercased.

-* Proposal: [SE-0161](0161-StringRevision1.md)
+* Proposal: [SE-NNNN](NNNN-string-revision-1.md)

@rjmccall rjmccall merged commit d959513 into swiftlang:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benrimmington benrimmington benrimmington left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airspeedswift @benrimmington @rjmccall