Skip to content

Proposal to synthesize Equatable/Hashable for value types. #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2017

Conversation

allevato
Copy link
Member

@allevato allevato commented May 8, 2017

No description provided.

@allevato
Copy link
Member Author

I've just pushed a small update to this proposal to clarify some things that have been discovered during the process of writing the WIP implementation above.

@benrimmington
Copy link
Contributor

@allevato Please see PR allevato#1

@benrimmington
Copy link
Contributor

@allevato Based on swiftlang/swift#9758 you might need to:

  • restore the original type declaration sentence;
  • remove the Location of synthesized conformances section.

@allevato
Copy link
Member Author

Thanks for the heads up, @benrimmington. I updated the proposal and it looks like swiftlang/swift#9758 just got merged so I'll bring my prototype in sync with that as well.

@trevor-e
Copy link

trevor-e commented Jun 13, 2017

It would be really awesome if a synthesis framework was exposed to developers so that libraries could leverage a form of code generation, similar to Java's annotation processing.

@lattner
Copy link
Collaborator

lattner commented Aug 9, 2017

Hi @allevato , I'd like to kick this off for formal review soon. Please check the proposal for any last minute revisions that you'd like. Is there an implementation available for this?

@CodaFi
Copy link
Contributor

CodaFi commented Aug 9, 2017

The implementation is available at swiftlang/swift#9619

@lattner
Copy link
Collaborator

lattner commented Aug 9, 2017

One other point, please make sure the test case includes a test for indirect enums.

@lattner
Copy link
Collaborator

lattner commented Aug 9, 2017

Thanks for the link @CodaFi . @allevato let me know when you're ready and I'll kick off review.

@lattner lattner merged commit 802c90d into swiftlang:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants