Skip to content

Amend SE-0224 to include #if compiler as well. #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Conversation

tkremenek
Copy link
Member

This is based on feedback in the review.

@tkremenek
Copy link
Member Author

@danielmartin This amends SE-0224 to include if compiler, which your implementation supports. The plan is to accept SE-0224 with this revision (which is already reflected in the implementation). Does this look good to you?

@benrimmington
Copy link
Contributor

@tkremenek Will the #if !compiler(>=4.2) and #if compiler(<4.2) conditions always be false?

I've just noticed that the #if compiler tests (added by @hartbit for SE-0212) were accidentally removed in swiftlang/swift#17689

@danielmartin
Copy link
Contributor

@tkremenek Looks good to me! I added some basic #if compiler tests to my implementation to prevent this feature to ever regress.

@tkremenek tkremenek merged commit fd9f3cb into master Sep 4, 2018
@tkremenek
Copy link
Member Author

@danielmartin That's great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants