Adds support for case insensitivity #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test |
milseman
reviewed
Feb 21, 2022
| return consumeScalar { | ||
| isCaseInsensitive | ||
| ? $0.properties.lowercaseMapping == s.properties.lowercaseMapping | ||
| : $0 == s |
There was a problem hiding this comment.
I still feel like there's quite a bit of duplicated code throughout. Would a helper function, similar to how consumeScalar is a helper function for making predicate-based scalar consumers, alleviate this some? Maybe something that is parameterized over case sensitivity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to do this all through consumer functions, but this allows for case insensitive matching throughout.