Avoid conforming String to Error in this module #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like an overly-broad conformance to add to swift-experimental-string-processing, and it doesn't look like anyone is calling report(). Do we need this?
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
rxwei
approved these changes
Mar 26, 2022
milseman
reviewed
Mar 28, 2022
| // Errors that may be thrown from default implementations | ||
| private enum ParticipantError: Error { | ||
| case unsupported | ||
| } |
There was a problem hiding this comment.
@hamishknight can you take a look?
There was a problem hiding this comment.
This is only used for testing AFAIK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like an overly-broad conformance to add to
swift-experimental-string-processing. Do we need this?
I noticed this while testing swiftlang/swift#36068, this trips the resilient retroactive conformance warning since we're building this with library evolution.