Skip to content

Rename _MatchingEngine to _RegexParser and fix CMake. #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Mar 28, 2022

The _MatchingEngine module no longer contains the matching engine. It has the regex AST and parser. This patch renames it to _RegexParserSupport.

Also fix the CMake build which has been broken for a while.

@rxwei rxwei force-pushed the rename-matchingengine-target branch from 363b36d to 9383953 Compare March 29, 2022 07:02
@rxwei
Copy link
Contributor Author

rxwei commented Mar 29, 2022

@swift-ci please test

@rxwei rxwei requested a review from milseman March 29, 2022 07:02
@rxwei rxwei marked this pull request as ready for review March 29, 2022 07:03
The _MatchingEngine module no longer contains the matching engine. It has the regex AST and parser. This patch renames it to `_RegexParser`.

Also fix the CMake build which has been broken for a while.
@rxwei rxwei force-pushed the rename-matchingengine-target branch from 9383953 to 96da785 Compare March 29, 2022 22:26
@rxwei rxwei changed the title Rename _MatchingEngine to _RegexParserSupport and fix CMake. Rename _MatchingEngine to _RegexParser and fix CMake. Mar 29, 2022
@rxwei
Copy link
Contributor Author

rxwei commented Mar 29, 2022

@swift-ci please test

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxwei rxwei merged commit 5a8c0cc into swiftlang:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants