Multi-line and extended delimiter literal lexing #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we don't try and print things like empty comma lists `,,,,` or redundant parens for concatenations that had their trivia filtered out.
Turns out this is a Unicode-defined thing.
Previously we would just lex to the end of the input, as it was assumed only single-line regex would be supported. Update the implementation to handle multi-line, and take account of PCRE global options.
Start lexing `/.../`, and allow any number of pound signs to surround it.
When an extended delimiter `#/` is followed by a newline, enter a multi-line mode where the literal may span multiple lines, and extended syntax is enabled by default.
Leave only `/.../` (and its extended syntax) enabled for now.
|
@swift-ci please test |
|
Given this patch allows the lexing of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the delimiter lexing logic to handle
/.../, an extended variant that allows an arbitrary number of balanced pounds, e.g##/.../##, and a multi-line mode when the extended variant starts with a newline. The multi-line mode uses extended regex syntax by default, allowing for non-semantic whitespace and end-of-line comments.Additionally, disable the
#|...|#,re'...', andrx'...'spellings for now.