Skip to content

Reenable motivation tests #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2022
Merged

Reenable motivation tests #344

merged 3 commits into from
Apr 26, 2022

Conversation

natecook1000
Copy link
Member

This includes a test that matches the RegexDSL proposal's example.

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 mentioned this pull request Apr 25, 2022
Merged
@natecook1000
Copy link
Member Author

@swift-ci Please test

milseman
milseman reviewed Apr 25, 2022
View reviewed changes
Tests/RegexBuilderTests/MotivationTests.swift Outdated
import RegexBuilder

#if os(macOS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, is this all that was needed this whole time? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, I guess not. Works on my machine! 🙃

@milseman
Copy link
Member

Apparently not:

Test Suite 'Selected tests' started at 2022-04-25 21:47:02.974Test Suite 'swift-experimental-string-processingPackageTests.xctest' started at 2022-04-25 21:47:02.975Test Suite 'RegexDSLTests' started at 2022-04-25 21:47:02.975Test Case '-[RegexBuilderTests.RegexDSLTests testBankStatement]' started.dyld: lazy symbol binding failed: Symbol not found: _$s10Foundation4DateV11FormatStyleVMa
  Referenced from: /Users/ec2-user/jenkins/workspace/pr-swift-experimental-string-processing-macos/branch-main/swift-experimental-string-processing/.build/x86_64-apple-macosx/debug/swift-experimental-string-processingPackageTests.xctest/Contents/MacOS/swift-experimental-string-processingPackageTests
  Expected in: /usr/lib/swift/libswiftFoundation.dylib

dyld: Symbol not found: _$s10Foundation4DateV11FormatStyleVMa
  Referenced from: /Users/ec2-user/jenkins/workspace/pr-swift-experimental-string-processing-macos/branch-main/swift-experimental-string-processing/.build/x86_64-apple-macosx/debug/swift-experimental-string-processingPackageTests.xctest/Contents/MacOS/swift-experimental-string-processingPackageTests
  Expected in: /usr/lib/swift/libswiftFoundation.dylib

Super annoying that it somehow still wants to link those symbols

@natecook1000
ifdef larger test back out again
8b9912d 
macOS CI is still broken on this one for some reason.
@natecook1000
Copy link
Member Author

@swift-ci Please test

milseman
milseman reviewed Apr 26, 2022
View reviewed changes
Tests/RegexBuilderTests/MotivationTests.swift
#if os(macOS)
// FIXME: macOS CI seems to be busted and Linux doesn't have FormatStyle
// So, we disable this larger test for now.
#if false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😩

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it goes

@natecook1000 natecook1000 merged commit d0598b7 into swiftlang:main Apr 26, 2022
@natecook1000 natecook1000 deleted the regexdsl_motivation branch April 26, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natecook1000 @milseman