Skip to content

Algorithm cleanup #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 26, 2022
Merged

Algorithm cleanup #351

merged 7 commits into from
Apr 26, 2022

Conversation

milseman
Copy link
Member

No description provided.

natecook1000
natecook1000 reviewed Apr 26, 2022
View reviewed changes
Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — as far as I can tell these hit all our edits. One note, and then I'll follow up later with info about empty matches.

@milseman milseman requested a review from itingliu April 26, 2022 00:23
@milseman
Copy link
Member Author

@swift-ci please test

itingliu
itingliu approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@itingliu itingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like separating regexcomponent-backed ones from the collection ones. Also I'm glad that we can land on Collection instead of BidirectionalCollection

@milseman milseman merged commit 1467470 into swiftlang:main Apr 26, 2022
@milseman milseman deleted the algorithm_cleanup branch April 26, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 natecook1000 left review comments

@itingliu itingliu itingliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milseman @natecook1000 @itingliu