Skip to content

Replace opaque results with generic parameters in Algorithms.swift #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

hamishknight
Copy link
Contributor

Work around the compiler bug rdar://92459215 by using generic parameters instead of opaque result types for a couple of methods.

Work around the compiler bug rdar://92459215 by
using generic parameters instead of opaque result
types for a couple of methods.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight requested a review from itingliu April 28, 2022 17:34
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milseman milseman merged commit b7fb965 into swiftlang:main Apr 28, 2022
@hamishknight hamishknight deleted the opaque-workaround branch April 28, 2022 18:37
milseman pushed a commit to milseman/swift-experimental-string-processing that referenced this pull request May 3, 2022
…wiftlang#367)

Work around the compiler bug rdar://92459215 by
using generic parameters instead of opaque result
types for a couple of methods.
milseman added a commit that referenced this pull request May 4, 2022
* Last pull from main for 5.7, part 1

Pulls in changes for:
  - SE-0350's API renaming
  - API names and enablement for the other 5 proposals
  - Drops un-needed Unicode data
  - CaptureList for communicating captures (spans parser and run-time)

* Replace opaque results with generic parameters in Algorithms.swift (#367)

Work around the compiler bug rdar://92459215 by
using generic parameters instead of opaque result
types for a couple of methods.

* Internalize operator for swift CI purposes

* Squash test, will enable later

Co-authored-by: Hamish Knight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants