Make variadic builder overloads AEIC (take 3) #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
reviewed
Jun 29, 2022
milseman
approved these changes
Jun 29, 2022
| _ component: some RegexComponent, | ||
| _ behavior: RegexRepetitionBehavior? = nil | ||
| ) -> Regex<Output> { | ||
| let kind: DSLTree.QuantificationKind = behavior.map { .explicit($0.dslTreeKind) } ?? .default |
There was a problem hiding this comment.
Minor code cleanup: what about an initializer that takes an optional behavior? Then this can just be .init(behavior) for these call sites.
add comments
|
@swift-ci please test |
Azoy
added a commit
to Azoy/swift-experimental-string-processing
that referenced
this pull request
Jun 29, 2022
Make variadic builder overloads AEIC (take 3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
_RegexFactoryinto s-p as a public underscored facility and de-publicizes some of the types in DSLTree, most notably Node. There are a few types that are still public spi for regexbuilder to work however.