Skip to content

Fix _testDSLCaptures #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix _testDSLCaptures #554

merged 1 commit into from
Jul 6, 2022

Conversation

hamishknight
Copy link
Contributor

Previously we would ignore the case where the match fails, but the test expects the match to succeed.

@hamishknight
Fix _testDSLCaptures
99002fa 
Previously we would ignore the case where the
match fails, but the test expects the match to
succeed.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

@Azoy Looks like a couple of tests fail with this change, can you take a look? Filed #555

@hamishknight hamishknight merged commit 970bd0e into swiftlang:main Jul 6, 2022
@hamishknight hamishknight deleted the ohno branch July 6, 2022 12:53
This was referenced Jul 6, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamishknight