Track source locations through the AST #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2021
Merged
milseman
force-pushed
the
abstract_syntax_orchard
branch
from
c487971 to
4984d75
Compare
|
Rebased and more fleshed out |
milseman
force-pushed
the
abstract_syntax_orchard
branch
from
4984d75 to
81e524f
Compare
Group and Quantification now track source locations, though many places in parser still fake them.
milseman
force-pushed
the
abstract_syntax_orchard
branch
from
81e524f to
118183b
Compare
|
@hamishknight can you take a look at this? @rxwei I fixed the bug where non-capturing groups were saying they were capturing. It wasn't too bad, just had to update some of the legacy compilation test cases. |
milseman
changed the title
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to track way more source locations, but I think it's important to merge this soon so we can build on it.