Better error printing #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
reviewed
Dec 17, 2021
milseman
changed the title
rxwei
reviewed
Dec 17, 2021
Comment on lines
8
to
15
| if !savePoints.isEmpty { | ||
| var result = "save points:\n" | ||
| for point in savePoints { | ||
| result += " \(point.describe(in: input))\n" | ||
| } | ||
| return result | ||
| } | ||
| return "" |
There was a problem hiding this comment.
Nit: May read better and reduce nesting if we early return with guard.
| var description: String { | ||
| String(describing: self.destructure) | ||
| extension Processor.SavePoint { | ||
| func describe(in input: Input) -> String { |
There was a problem hiding this comment.
Suggested change
| func describe(in input: Input) -> String { | |
| func description(in input: Input) -> String { |
Nit: The method doesn't have side effects. Therefore suggesting a noun phrase instead of an imperative.
rxwei
approved these changes
Dec 17, 2021
|
Ok I'm confused. I thought the ME bug fix made it in somewhere else, but if this is what pulls it in fine. Maybe I just don't know how to do |
milseman
force-pushed
the
custom_error_printable
branch
from
efceaa6 to
d233b86
Compare
milseman
changed the title
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better printing for our parse errors