Add a group around member types used in return clauses. #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the group, the pretty printer would add a newline at the first break in the return clause where the column limit would overflow. This could fall inside of a member type identifier, before the dot. That results in odd formatting where a func decl has its return clause partially on the first line and partially on the second line (which is only allowed for tuples because of the opening paren special case). With the group, the func decl breaks before the -> when the type would overflow the line.
allevato
approved these changes
Feb 24, 2020
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
* Add zero width space to escape emoji shortcodes * Add changelog entries for swiftlang#149
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
* Revert "Add zero width space to escape emoji shortcodes (swiftlang#149)" This reverts commit aeed63c. * Extract StringProtocol helper methods into separate file * Add and apply escapingEmojiShortcodes property where necessary * Add Changelog entry for swiftlang#167 * Fix Swift 5.2 error 'closure containing control flow statement cannot be used with function builder'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the group, the pretty printer would add a newline at the first break in the return clause where the column limit would overflow. This could fall inside of a member type identifier, before the dot. That results in odd formatting where a func decl has its return clause partially on the first line and partially on the second line (which is only allowed for tuples because of the opening paren special case).
With the group, the func decl breaks before the -> when the type would overflow the line.