Don't propagate the diagnostic engine when formatting. #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supresses printing diagnostic messages when using the format mode. When formatting, the issues in the source are either going to be fixed or they can't be fixed automatically. In either case, the formatter should be quiet about it. Linting continues to use the `DiagnosticEngine` so that lint findings are displayed as before.
allevato
approved these changes
Feb 27, 2020
natecook1000
added a commit
to natecook1000/swift-format
that referenced
this pull request
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supresses printing diagnostic messages when using the format mode. When formatting, the issues in the source are either going to be fixed or they can't be fixed automatically. In either case, the formatter should be quiet about it.
Linting continues to use the
DiagnosticEngineso that lint findings are displayed as before.