Restore some discretionary newlines from PR #143 #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several breaks were changed to disallow discretionary newlines in swiftlang#143. In practice, some of these breaks actually require a more nuanced approach because grouping around the content after the `:` is frequently subjective. Depending on the length of the label/key before the `:` and the actual expr or type, it varies whether a group should be around the content after the `:`. The formatter's current model doesn't support modifying the tokens to add/remove group tokens once the token stream is created. In a future patch, it would be nice to have a way to switch between grouping and not grouping the content after the `:` based on the preceding key or label. Reverted `ignoresDiscretionary` breaks include after the colon in... - a dictionary type - a dictionary element - a function call argument - a function decl parameter - a generic parameter - a tuple type - a tuple expr element
allevato
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several breaks were changed to disallow discretionary newlines in #143. In practice, some of these breaks actually require a more nuanced approach because grouping around the content after the
:is frequently subjective. Depending on the length of the label/key before the:and the actual expr or type, it varies whether a group should be around the content after the:. The formatter's current model doesn't support modifying the tokens to add/remove group tokens once the token stream is created.In a future patch, it would be nice to have a way to switch between grouping and not grouping the content after the
:based on the preceding key or label.Reverted
ignoresDiscretionarybreaks include after the colon in...