Add a consistent group around if-stmts. #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
reviewed
Apr 9, 2020
| } | ||
| if let foo = getmyfoo(), let bar = getmybar(), | ||
| foo.baz && bar.baz && someOtherCondition | ||
| { foo() } |
There was a problem hiding this comment.
I think it would be nice to have these breaks fire too when the condition wraps, if possible—that way, the body is only condensed to one line if the whole statement fits on one line. I'm surprised that doesn't happen already, since I'd expect the reset break that did fire to do so consistently with the breaks inside the braces. What's going on there, and would it be a lot harder to make it do that?
There was a problem hiding this comment.
I intentionally only added the consistent group when there is an else clause, since the problem of inconsistent breaks around the clauses don't exist when there's only 1 clause. It's a simple change to unconditionally add the consistent group though.
The consistent group forces the bodies of if-stmts with else clauses to have breaks around all braces when the stmt spans multiple lines. Previously. the breaks around the braces only fired if the body didn't fit on the line. That behavior lead to hard to read if-stmts because if was unclear where conditions stopped and the body started.
dylansturg
force-pushed
the
better_if_stmts
branch
from
bdbede9 to
33ea88a
Compare
allevato
approved these changes
Apr 9, 2020
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
* Use prebuilt Docker image * Add Changelog entry for swiftlang#185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consistent group forces the bodies of if-stmts with else clauses to have breaks around all braces when the stmt spans multiple lines. Previously. the breaks around the braces only fired if the body didn't fit on the line. That behavior lead to hard to read if-stmts because if was unclear where conditions stopped and the body started.