Disallow line breaks in completely empty array and dict exprs. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to have a newline between the square brackets when there's nothing, other than a `:` for dict exprs, between the brackets.
allevato
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to have a newline between the square brackets when there's nothing, other than a
:for dict exprs, between the brackets.Originally, I was making this change to mitigate a problem with indentation of this types of exprs in a function call. While this does fix the problem for arrays and dicts, it's not a suitable solution for closures. Regardless of future changes that would better mitigate the indentation problem, I think disallowing newlines in this contexts is an improvement.