Skip to content

Correct version string for --version flag (master) #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Correct version string for --version flag (master) #202

merged 1 commit into from
Jun 12, 2020

Conversation

MPLew-is
Copy link
Contributor

This is going to be a pain to keep bumping for every release, but this change at least gets the correct version in for now.

Feel free to close this or #201 if you don't feel both are necessary, but since it seems like you'd cherry pick this commit anyway between the branches, I figured I'd save you some time and make them separate PRs.

This is going to be a pain to keep bumping for every release, but this change at least gets the correct version in for now.
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look at this.

Long-term, I think it would be ideal if Swift Package Manager had some way to automatically generate and inject version info for projects—I've been meaning to start a conversation about this on the forums but haven't had the time to really foster that discussion, but maybe I should just kick something off and see where it goes.

In the meantime, it'll be good to have these strings actually reflect reality since we've cut a couple releases already.

@allevato allevato merged commit 8f52d5c into swiftlang:master Jun 12, 2020
@MPLew-is
Copy link
Contributor Author

I wholeheartedly agree it would be useful to have some way of accessing some versioning information from Swift Package Manager, but I'm not sure what easy mechanism there would be for embedding that information into the end binary. Would love to see a discussion on the subject though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants