Use a wrapper type instead of retro-conforming FileHandle to TextOutputStream.
#290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utputStream`. TSCBasic has a Windows-only retroactive `FileHandle: WritableByteStream` conformance which confers `TextOutputStream` conformance, conflicting with the one in our package. Instead of trying to reconcile this across all platforms, just replace our retroactive conformance with a new wrapper type which can never conflict with anything from an outside package.
compnerd
approved these changes
Mar 22, 2022
This was referenced Mar 22, 2022
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Mar 22, 2022
Use a wrapper type instead of retro-conforming `FileHandle` to `TextOutputStream`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSCBasic has a Windows-only retroactive
FileHandle: WritableByteStreamconformance which confers
TextOutputStreamconformance, conflicting with theone in our package. Instead of trying to reconcile this across all platforms,
just replace our retroactive conformance with a new wrapper type which can
never conflict with anything from an outside package.