Don't emit AlwaysUseLowerCamelCase for decls that override
#295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `override` modifier. Specifically this applies to function and variable decls. When one of those is overriding a decl in a super class, then this specific instance of the decl cannot be renamed to fix the issue. The original decl in the super class must be renamed. The finding is still raised if the super class is linted. Raising the finding in every subclass is noisy and frustrating, since it can't really be fixed in the subclass.
allevato
approved these changes
Apr 18, 2022
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Sep 13, 2022
…nings Don't emit AlwaysUseLowerCamelCase for decls that `override`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically this applies to function and variable decls. When one of those is overriding a decl in a super class, then this specific instance of the decl cannot be renamed to fix the issue. The original decl in the super class must be renamed. The finding is still raised if the super class is linted.
Raising the finding in every subclass is noisy and frustrating, since it can't really be fixed in the subclass.