Don't overwrite files if they are unchanged #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always writing to the file, even if unchanged, updates the modified time and prevents incremental builds in Xcode.
myyra
changed the title
allevato
approved these changes
Apr 21, 2022
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Sep 13, 2022
…nged Don't overwrite files if they are unchanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always writing to the file, even if unchanged, updates the modified time and prevents incremental builds in Xcode. This PR adds a simple equal check before actually writing anything, preserving timestamps if nothing in the output was changed.
I don't remember this being an issue for me before, but I also couldn't find any change that would've started to cause this. In any case, this completely resolves the problem.
In my testing with a small folder of files, this change also makes the formatting slightly faster.