Fix ignore-unparsable-files flag so that it works. #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag was broken after SwiftSyntax switched how it represents unsupported syntax nodes, from Unknown* type nodes to Missing* nodes. Now the tool exits early whenever there are parsing diagnostics, and `--ignore-unparsable-files` disables emitting those diagnostics. Regardless of the flag's value, the formatter won't try to operate on a file with any parsing diagnostics.
allevato
approved these changes
Oct 12, 2022
| for diagnostic in diagnostics { | ||
| let location = diagnostic.location(converter: expectedConverter) | ||
| parsingDiagnosticHandler(diagnostic, location) | ||
| } | ||
| } | ||
|
|
||
| guard diagnostics.isEmpty else { | ||
| throw SwiftFormatError.fileContainsInvalidSyntax |
There was a problem hiding this comment.
I wonder if we should eventually ditch the parsingDiagnosticsConsumer model and just throw the array of diagnostics as part of this error, since we don't plan on doing anything else after that.
That's a bigger API change though so we can save it for later, to make sure there aren't any other weird side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag was broken after SwiftSyntax switched how it represents unsupported syntax nodes, from Unknown* type nodes to Missing* nodes. Now the tool exits early whenever there are parsing diagnostics, and
--ignore-unparsable-filesdisables emitting those diagnostics. Regardless of the flag's value, the formatter won't try to operate on a file with any parsing diagnostics.