Skip to content

Update ArgumentParser dependency in Package.swift #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

MaxDesiatov
Copy link
Contributor

Synchronized with swiftlang/swift-syntax#1408.

1.2.2 is the version of ArgumentParser used by the toolchain, according to the checkout config: https://github.com/apple/swift/blob/277674a642b058fe95c37e24d5c861c5b81b6a82/utils/update_checkout/update-checkout-config.json#L103

Sticking to the old versions like 1.0.x and 1.1.x has negative downstream effects, since tools using SwiftSyntax (like swift-format) are restricted to these versions too, which can easily conflict with other packages.

A more general solution could be to rely on SemVer and use .upToNextMajor instead of .upToNextMinor.

Synchronized with swiftlang/swift-syntax#1408.

1.2.2 is the version of ArgumentParser used by the toolchain, according to the checkout config: https://github.com/apple/swift/blob/277674a642b058fe95c37e24d5c861c5b81b6a82/utils/update_checkout/update-checkout-config.json#L103

Sticking to the old versions like 1.0.x and 1.1.x has negative downstream effects, since tools using SwiftSyntax (like `swift-format`) are restricted to these versions too, which can easily conflict with other packages.

A more general solution could be to rely on SemVer and use `.upToNextMajor` instead of `.upToNextMinor`.
@MaxDesiatov MaxDesiatov requested a review from allevato March 14, 2023 17:56
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov MaxDesiatov merged commit 89a0b6f into main Mar 16, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/update-argument-parser branch March 16, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants