Skip to content

Rename children of differentiability nodes #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Rename children of differentiability nodes #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/SwiftFormatPrettyPrint/TokenStreamCreator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2532,9 +2532,9 @@ fileprivate final class TokenStreamCreator: SyntaxVisitor {
// This node encapsulates the entire list of arguments in a `@differentiable(...)` attribute.
var needsBreakBeforeWhereClause = false

if let diffParamsComma = node.parametersComma {
if let diffParamsComma = node.argumentsComma {
after(diffParamsComma, tokens: .break(.same))
} else if node.parameters != nil {
} else if node.arguments != nil {
// If there were diff params but no comma following them, then we have "wrt: foo where ..."
// and we need a break before the where clause.
needsBreakBeforeWhereClause = true
Expand Down Expand Up @@ -2571,7 +2571,7 @@ fileprivate final class TokenStreamCreator: SyntaxVisitor {
// The comma after originalDeclName is optional and is only present if there are diffParams.
after(node.comma ?? node.originalDeclName.lastToken(viewMode: .sourceAccurate), tokens: .close)

if let diffParams = node.parameters {
if let diffParams = node.arguments {
before(diffParams.firstToken(viewMode: .sourceAccurate), tokens: .break(.same), .open)
after(diffParams.lastToken(viewMode: .sourceAccurate), tokens: .close)
}
Expand Down