Fix missing break in nested IfConfig decls. Fixes #779. #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Jul 25, 2024
| @@ -1453,6 +1453,8 @@ fileprivate final class TokenStreamCreator: SyntaxVisitor { | |||
| } | |||
|
|
|||
| override func visit(_ node: IfConfigDeclSyntax) -> SyntaxVisitorContinueKind { | |||
| // there has to be a break after an #endif | |||
| after(node.poundEndif, tokens: .break(.same, size: 0)) | |||
There was a problem hiding this comment.
Out of interest? What does size: 0 mean here?
There was a problem hiding this comment.
This is the number of blank spaces that would be inserted, if this break was interpreted as a space instead of a newline. To be honest it feels like this should be a non-discretionary line break, but this is how it's done in a very similar case PostfixIfConfigExpr, so I am following that.
ahoppen
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.