Guard macro declarations behind hasFeature(Macros)
#1071
Conversation
To enable building this package with a "minimal" Swift toolchain whose compiler does not have support for macros, guard the macro declarations behind `#if hasFeature(Macros)`. This has no effect on anything but the toolchain bootstrap process.
|
@swift-ci please test |
| @@ -27,6 +27,8 @@ public struct Expression<each Input, Output> : Sendable { | |||
| } | |||
| } | |||
|
|
|||
| #if hasFeature(Macros) | |||
There was a problem hiding this comment.
Just confirming, do we need to worry about this in our unit tests which use the macro or are we not expected to ever try to build tests with a minimal compiler?
Additionally, do we need to handle avoiding building the macro itself? IIRC if the cmake build is not provided with a path to the built macro, it will attempt to build the macro automatically and SwiftPM builds will always build the macro. I suspect that we don't expect to be able to build via SwiftPM with a minimal toolchain, but is there anything that needs to be done on the CMake side to avoid invoking a build of the macro library when the compiler doesn't have this feature?
There was a problem hiding this comment.
No, we don't have to worry about tests. We don't care whether that first stage passes tests, it just needs to build the second stage.
I don't think we need to avoid building the macro library, either. It's just unused.
To enable building this package with a "minimal" Swift toolchain whose compiler does not have support for macros, guard the macro declarations behind
#if hasFeature(Macros). This has no effect on anything but the toolchain bootstrap process.