Skip to content

Add linked-on-or-after check for empty URL.host() #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Add linked-on-or-after check for empty URL.host() #1092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Sources/FoundationEssentials/URL/URL.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,6 +1236,16 @@ public struct URL: Equatable, Sendable, Hashable {
return nil
}

#if FOUNDATION_FRAMEWORK
// Linked-on-or-after check for apps which expect .host() to return nil
// for URLs like "https:///". The new .host() implementation returns
// an empty string because according to RFC 3986, a host always exists
// if there is an authority component, it just might be empty.
if Self.compatibility2 && encodedHost.isEmpty {
return nil
}
#endif

func requestedHost() -> String? {
let didPercentEncodeHost = hasAuthority ? _parseInfo.didPercentEncodeHost : _baseParseInfo?.didPercentEncodeHost ?? false
if percentEncoded {
Expand Down