Fix WASI build of _copyDirectoryMetadata
#1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended attributes don't exist in WASI, so we need to exclude the use of xattr-related APIs including `flistxattr`.
|
@swift-ci test |
kateinoigakukun
added a commit
to swiftwasm/swiftwasm-build
that referenced
this pull request
Dec 13, 2024
jmschonfeld
approved these changes
Dec 13, 2024
kateinoigakukun
added a commit
to kateinoigakukun/swift-foundation
that referenced
this pull request
Dec 17, 2024
Extended attributes don't exist in WASI, so we need to exclude the use of xattr-related APIs including `flistxattr`.
itingliu
pushed a commit
that referenced
this pull request
Jan 3, 2025
* Fix WASI build of `_copyDirectoryMetadata` (#1094) Extended attributes don't exist in WASI, so we need to exclude the use of xattr-related APIs including `flistxattr`. * Follow-up fixes to make it work with wasi-libc (#1095) * Gate `fchown` and `fchmod` calls behind `os(WASI)` They are not available on WASI, so we gate them behind `os(WASI)`. * Add missing constant shims for wasi-libc * Use `futimens` instead of legacy `futimes` wasi-libc does not provide `futimes` as it is a legacy function. https://github.com/WebAssembly/wasi-libc/blob/574b88da481569b65a237cb80daf9a2d5aeaf82d/libc-top-half/musl/include/sys/time.h#L34 * Don't try to set extended attributes on Android (#1106) Normal users don't have permission to change these, even for their own files. --------- Co-authored-by: finagolfin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended attributes don't exist in WASI, so we need to exclude the use of xattr-related APIs including
flistxattr.