Implement LockedState for Musl #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
itingliu
approved these changes
Dec 20, 2024
iCharlesHu
approved these changes
Dec 20, 2024
parkera
approved these changes
Dec 20, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Dec 20, 2024
jmschonfeld
added a commit
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we're missing a few conditionals in the
LockedStateimplementation that leftLockedStateacting as a no-op for the static linux SDK. This results in the lack of synchronization of caches in swift-foundation for that platform. I went ahead and added the right conditionals for Musl (same as Glibc) and also added an explicit#elsecase with a#errorso that we can more quickly and easily detect platforms for which we have not implemented synchronization primitives here.I've confirmed that running the sample program in the linked issue produces the segmentation fault but with this change the fault no longer occurs.
Resolves #1100