Update SF-0007 Subprocess to version 8 #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
force-pushed
the
charles/subprocess-proposal-v8
branch
from
2f11c4d to
56d57fb
Compare
itingliu
approved these changes
Mar 14, 2025
| #if SubprocessSpan | ||
| extension OutputProtocol { | ||
| // Default implementation provided | ||
| public func output(from buffer: some Sequence<UInt8>) throws -> OutputType { ... } |
There was a problem hiding this comment.
Styling nit: unnecessary trailing {...}
There was a problem hiding this comment.
I added this specially to mean this is a "default implementation" instead of protocol requirement since the requirement itself is declared above 😅
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8: Removing
ManagedInputProtocolandManagedOutputProtocolInputProtocolandOutputProtocolto not exposeFileDescriptordirectlySubprocessSpantraitPipeTeardownStep.gracefulShutDown(alloweDurationToNextStep:)and add Windows support