ISO8601 DateComponents format style #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
parkera
force-pushed
the
parkera/iso8601_style
branch
from
77493e1 to
2bf9583
Compare
parkera
force-pushed
the
parkera/iso8601_style
branch
from
2bf9583 to
025bf8c
Compare
|
@swift-ci test |
itingliu
reviewed
Apr 3, 2025
| @available(FoundationPreview 6.2, *) | ||
| extension DateComponents { | ||
| /// Options for generating and parsing string representations of dates following the ISO 8601 standard. | ||
| public struct ISO8601FormatStyle : Sendable, Codable { |
There was a problem hiding this comment.
The proposal has it conform to Hashable as well. Is that missing here?
|
|
||
| @available(FoundationPreview 6.2, *) | ||
| public extension FormatStyle where Self == DateComponents.ISO8601FormatStyle { | ||
| static var iso8601: Self { |
There was a problem hiding this comment.
The proposal has it named iso8601Components. I think it's ok to call it iso8601 here (unlike the one below for RegexComponent, but not sure what you ended up deciding on
There was a problem hiding this comment.
I left this one as iso8601 and made the regex one “components” (and also made that consistent with HTTP)
|
@swift-ci test |
itingliu
approved these changes
Apr 4, 2025
theMomax
pushed a commit
that referenced
this pull request
Apr 10, 2025
* ISO8601 DateComponents style * Add Hashable to ISO8601FormatStyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ISO8601 components format style. See pitch thread.
Resolves:
#323
#967
#1159