Support Windows URL paths in FoundationEssentials #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
jrflat
changed the title
jmschonfeld
approved these changes
May 9, 2024
There was a problem hiding this comment.
Code looks fine overall to me, but I'll let @compnerd validate the Windows behavior 🙂
|
Oops, fixing the Windows build failures now. |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
compnerd
approved these changes
May 10, 2024
|
One thing that shows up with this: |
|
I think that this is due to the path containing |
Thanks for pointing this out! I think the last two commits might help address this. I also opted to keep server/share as part of the path to let the Windows APIs handle it, since I think setting |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
|
This is definitely doing way better! There are a few hangs that need to be diagnosed still, but this is the state after this change: |
|
Ah, looks like the |
|
I'm going to merge this to unblock other work, but I will open up a new PR to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports initializing file URLs with Windows paths. Allow
"\"as the path separator, allow UNC paths ("\\") with host, and allow/standardize drive letter paths ("C:"). However, we always store the URL with forward slashes to stay consistent for path parsing operations. I thinkString.withNTPathRepresentation(_:)should then be used to convert any"/"back to"\"before consulting the file system on Windows. @compnerd thoughts on this approach?The file URL initializers also now resolve against the base URL (or current directory) for checking if the file is a directory.