Update FileManager for use by SCL-F #609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two pieces of
FileManager
that need to be updated so that swift-corelibs-foundation can use thisFileManager
implementation:NSNumber
type. However, since swift-foundation does not know aboutNSNumber
, it currently doesn't work.NSNumber
is implicitly bridged to concrete numeric types, but not to an existential type likeany BinaryInteger
. So to fix this, when reading numeric attributes we now try a direct dynamic cast to the target type (as? T
) which will succeed ifvalue
is anNSNumber
, then we try a dynamic cast toany BinaryInteger
to catch any other numeric types